According to the release:

Adds experimental PostgreSQL support

The code was written by Cursor and Claude

14,997 added lines of code, and 10,202 lines removed

reviewed and heavily tested over 2-3 weeks

This makes me uneasy, especially as ntfy is an internet facing service. I am now looking for alternatives.

Am I overreacting or do you all share the same concern?

  • SanPe_@lemmy.world
    link
    fedilink
    English
    arrow-up
    3
    ·
    1 hour ago

    I’m so tired of that.

    I’m using it for scripts notifications + unifiedpush. I don’t know where to start to find the fitting alternative.

    • GreenKnight23@lemmy.world
      link
      fedilink
      English
      arrow-up
      2
      ·
      10 hours ago

      been using EMQX plus an MQTT client on my phone for a few months now, I like it better than gotify since the app was chewing through my battery like a vampire.

      it might be better now since my issues happened three-ish years ago.

      • SayCyberOnceMore@feddit.uk
        link
        fedilink
        English
        arrow-up
        2
        ·
        4 hours ago

        This EMQX?

        Seems it’s no longer FOSS?

        I’ve been using Gotify for a few notifications from Home Assistant and it doesn’t appear to be eating my battery.

        It’s a little more responsive than ntfy - sometimes ntfy doesn’t alert for ages after the trigger (could be phone power saving the wifi…), but then I also get realerts from yesterday… not had that with Gotify.

        • GreenKnight23@lemmy.world
          link
          fedilink
          English
          arrow-up
          1
          ·
          3 hours ago

          that’s the one.

          FOSS or not, it still runs just fine on my infra. I prefer it over something like rabbitmq because it has a pretty slick admin webgui.

          I’ll have to give gotify another try.

  • patrick@lemmy.bestiver.se
    link
    fedilink
    English
    arrow-up
    92
    arrow-down
    3
    ·
    17 hours ago

    It looks like that tool is more or less built by a single developer (you already trust their judgment anyways!), and even though the code came through in a single PR it was a merge from a branch that had 79 separate commits: https://github.com/binwiederhier/ntfy/pull/1619

    Also glancing through it a bit, huge portions of that are straightforward refactors or even just formatting changes caused by adding a new backend option.

    I’m not going to say it’s fine, but they didn’t just throw Claude at a problem and let it rewrite 25k lines of code unnecessarily.

  • Phoenixz@lemmy.ca
    link
    fedilink
    English
    arrow-up
    59
    arrow-down
    4
    ·
    18 hours ago

    I’m a developer

    I sometimes sometimes use AI for an answer to a complicated problem because normally I’d open up 20 pages , have to go through them all to find the right answer

    AI gets me the answer right away, though it likely is completely wrong or at least partially wrong. Either way, it gives me a general direction and with that I only have to search through one or two pages to confirm, so the same process is just a little faster.

    I laso have used AI on a couple of occasions to ask it to write code for a complicated problem. Again, you don’t copy the code, god no, it’s always the worst, and it is in 80% of the cases still at least riddled with bugs, or just complete bullshit. However, it might give me an alternative idea or a direction to take to implement or fix this complicated feature problem.

    That’s the extent to which I’ve used AI and for the foreseeable future that won’t change because AI still can’t code. It’s still wildly flailing around and it might produce something that implements a certain functionality, but it’s a guarantee that that functionality will have more bugs and security holes than features

    • s3rvant@lemmy.ml
      link
      fedilink
      English
      arrow-up
      21
      arrow-down
      1
      ·
      17 hours ago

      I am also a developer and agree entirely.

      Asking for advice, examples or the occasional boilerplate is at most how I use AI and certainly not integrated directly into my IDE.

    • DonutsRMeh@lemmy.world
      link
      fedilink
      English
      arrow-up
      3
      arrow-down
      1
      ·
      11 hours ago

      I understand this comment. AI sometimes saves a ton of mental power and time when I’m stuck on an issue. It can give some really good suggestions. Also, AI is a godsend for frontend shit. I don’t care what y’all say, I’m never touching CSS and HTML ever again. lmao.

  • Erik-Jan@fosstodon.org
    link
    fedilink
    arrow-up
    105
    ·
    21 hours ago

    @ueiqkkwhuwjw just this quote at the start of the release notes

    > 14,997 added lines of code, and 10,202 lines removed, all from one pull request

    This is already a major red flag even without the ai stuff right? Can’t believe anyone would flaunt that like this.

    • dev_null@lemmy.ml
      link
      fedilink
      English
      arrow-up
      1
      ·
      edit-2
      43 minutes ago

      The “single pull request” is a merge release from 79 separate commits. It’s the sum of all work, it doesn’t mean all of it was changed in one go.

  • LiveLM@lemmy.zip
    link
    fedilink
    English
    arrow-up
    37
    arrow-down
    1
    ·
    edit-2
    19 hours ago

    Look, if he wanted to introduce AI code, whatever, but doing it all at once in a 14k line change is crazy.

    Surely it would be better to introduce AI by letting it handle misc changes here and there instead of starting with the “biggest release ever done” (his words), no?

  • notabot@piefed.social
    link
    fedilink
    English
    arrow-up
    56
    arrow-down
    2
    ·
    20 hours ago

    I’m assuming this is some sort of canary message to indicate that the code base has been compromised, the author can’t talk about it, and everyone should immediately stop using the service. Surely no-one would be unwise enough to commit this otherwise?

    Even ignoring the huge red LLM flag, a 25kLOC delta in a single PR should be cause for instant rejection as there’s no way to fully understand or test it, let alone in 2-3 weeks.

    • ExFed@programming.dev
      link
      fedilink
      English
      arrow-up
      17
      arrow-down
      2
      ·
      19 hours ago

      25kLOC delta in a single PR should be cause for instant rejection

      Not to pick at nits, but it would be VERY different if it was 1k lines added and 24k lines removed. There’s something extremely satisfying about removing 10k+ lines of unnecessary code.

      • notabot@piefed.social
        link
        fedilink
        English
        arrow-up
        8
        ·
        18 hours ago

        Sure, that would be a little different, but unless you could make a convincing argument, backed up with a solid set of unit tests, at the least, as to why and how you were able to remove that much code whilst only adding a comparatively small amount, I’d still be inclined to reject it and ask for it to be broken down into smaller units.

        Now, that explaination might be something along the lines of it being dead code that is not called from anywhere, or even that it was a patched version of an upstream library, and the patch is now included in that upstream, in which case, fair enough, good work, and thanks very much. As a rewrite or refactor though, it’s too big to sensibly review and needs breaking down into separate features.

        • ExFed@programming.dev
          link
          fedilink
          English
          arrow-up
          2
          ·
          17 hours ago

          Absolutely, the author needs to be able to reason about their changes, no matter what. However, the reason why I think the two situations are fundamentally different, though, is that it’s a lot easier to validate the existence of features than it is the non-existence of bugs or malicious behavior. The biggest risk to removing code is breaking preexisting features, whereas the biggest risk to adding code is introducing malicious behavior.

  • d15d@feddit.org
    link
    fedilink
    English
    arrow-up
    173
    ·
    1 day ago

    They are not even trusting it themselves. This is from the release notes

    I’ll not instantly switch ntfy.sh over. Instead, I’m kindly asking the community to test the Postgres support and report back to me if things are working

    Fuck that.

      • callmemagnus@lemmy.world
        link
        fedilink
        English
        arrow-up
        4
        arrow-down
        1
        ·
        4 hours ago

        Consider a donation to help people providing you the open source software you seem to depend upon.

        Usage of a helper tool to perform tasks on code whether it is AI or the IDE internal features can reduce the work load of benevolent developers who has not asked you to use their softwares.

        Maybe the language was not appropriate but get real. With the little revenue generated by the usage of people complaining, the use of AI agentic coding might be the only way to being features without pushing benevolent devs to burnout.

        • Mirror Giraffe@piefed.social
          link
          fedilink
          English
          arrow-up
          1
          ·
          24 minutes ago

          You are completely correct, and to be honest I’ve tested commercial product features in prod as well on teams that have the capacity to handle it and make a living on it, unlike this maintainer.

          I’m also experimenting heavily with vibe coding and I think it has many uses for a seasoned programmer while getting a lot of flak.

          Of course there are issues and problems with it, but for me it had been helping out a lot.

      • Railcar8095@lemmy.world
        link
        fedilink
        English
        arrow-up
        37
        arrow-down
        2
        ·
        23 hours ago

        Test in production is the best. We spent months warning from data bugs and nobody bat an eye (upstream bug, not our responsibility but we noticed) When it was d launched in prod we just pointed out the bug that nobody fixed was still there and immediately a war room was formed and the bug fixed within an hour.

        It honestly seems more efficient to let shit hit the fan than to fight everybody to do their job.

        • hornedfiend@piefed.social
          link
          fedilink
          English
          arrow-up
          1
          ·
          edit-2
          4 hours ago

          Testing in production is the most idiotic last 10 years or so concept, which is mainly driven by incompetence of project managers.

          Imagine if you get sold a car by a company, for 100k, then it starts having major issues and the car company tells you: “we’ll fix it”.

          While that does not necessarily apply to software or services or webapps, the logic still stands. You are selling bugs to people. Bugs that could have been cought, with some risk management and planning.

          Edit: F-ing ios keyboard.

          • Railcar8095@lemmy.world
            link
            fedilink
            English
            arrow-up
            1
            ·
            2 hours ago

            which is mainly driven by incompetence of project managers.

            I completely agree. I work on an internal solution, which is a part of a very large product. It’s not a live product, only part of a pipeline that runs on a predetermined schedule. Our bit is the only one with actual business/performance KPIs, most of the other teams measure only “user story/CR points”. If the other teams screw up, it will impact our performance unless we prove it’s their fault. And of it’s their fault, they open a US/bug which improves their metrics (one more US closed). Our team has to think ahead and try to do things well in one go, because our bugfixing doesn’t count as work. But our speed is measured against people who benefits from half doing stuff. When we did massive effort, we got complaints we were slow. Now we do less effort and once every blue moon we have to do a hotfix. Most often than not when we have an production issue is due to the other teams that run before us on the pipeline, so we even had to develop checks to our input because they won’t add checks to their outputs. And they won’t because that’s a CR that requires extra funding that’s not approved, but we had to create them for our own sanity.

            Yes, I’m looking to move out haha

        • x00z@lemmy.world
          link
          fedilink
          English
          arrow-up
          36
          ·
          23 hours ago

          You’re implying a shitty capitalist company that nobody cares for if it burns down. A tool like this though that is self-hosted by a lot of people (29.1k stars on GH!) and that is internet-facing is very different.

        • Mirror Giraffe@piefed.social
          link
          fedilink
          English
          arrow-up
          5
          arrow-down
          1
          ·
          23 hours ago

          For sure, the song of the hero who fixed the production bug is oft sang at meetings but the loser who prevented the bug to begin with gets no credit.

    • osanna@lemmy.vg
      link
      fedilink
      English
      arrow-up
      1
      ·
      11 hours ago

      Ntfy.sh is the hosted version. Hosted by the author. Ntfy (android, ios) is the app that you use as a client.

      • Lumisal@lemmy.world
        link
        fedilink
        English
        arrow-up
        3
        ·
        11 hours ago

        I’ve never used ntfy.sh

        I’ve only used Ntfy app for Universal Push that some apps need, and they recommend ntfy. Does this affect the app then? Ah, if so, what alternative can I use for just that purpose?

        • osanna@lemmy.vg
          link
          fedilink
          English
          arrow-up
          3
          ·
          11 hours ago

          Gotify is probably the next best thing, at least in terms of self hosted. Though doesn’t have the wide support of ntfy.

  • newtothis3@lemmy.world
    link
    fedilink
    English
    arrow-up
    2
    ·
    11 hours ago

    In reality how big of a risk it currently is? I just started to use it just for fun and personal projects. If previous version didn’t have security vulnerabilties then then there is no rush to update or am i missing something?

  • Kushan@lemmy.world
    link
    fedilink
    English
    arrow-up
    21
    ·
    19 hours ago

    Fuck, I love ntfy, it’s one of the best self hosted push notification systems I’ve used. It has been flawless so far.

    Don’t like this.

  • hendrik@palaver.p3x.de
    link
    fedilink
    English
    arrow-up
    97
    ·
    1 day ago

    Uh. I’d really prefer if people experimented with new technology a bit more cautiously and not directly jump to “the biggest release […] ever done”.

      • CorrectAlias@piefed.blahaj.zone
        link
        fedilink
        English
        arrow-up
        27
        arrow-down
        2
        ·
        18 hours ago

        They just replied:

        What gave you the idea that this was a full rewrite? I moved things around with AI and added postgres support for the queries. Nobody has ever reviewed and tested anything more thoroughly than I did with this branch.

        You are twisting what it actually is. You are assuming something that is not true.

        This makes me think that they didn’t review or test it at all, lmao

        • Fmstrat@lemmy.world
          link
          fedilink
          English
          arrow-up
          12
          ·
          15 hours ago

          This is the biggest release I’ve ever done on the server. It’s 14,997 added lines of code, and 10,202 lines removed

      • hendrik@palaver.p3x.de
        link
        fedilink
        English
        arrow-up
        15
        ·
        edit-2
        17 hours ago

        Thanks for the link! As a short aside for the other people here: Try not to spam developers. That usually achieves the opposite and makes them miserable, when we want them to not burn out, and write good software for us. A thumbs-up emoji is the correct reaction for the average person. Or for the pros - a code-review highlighting specific issues within the code.

    • cecilkorik@piefed.ca
      link
      fedilink
      English
      arrow-up
      19
      ·
      18 hours ago

      I think there’s room for a little bit of nuance that page doesn’t do a great job of describing. In my opinion there’s a huge difference between volunteer maintainers using AI PR checks as a screening measure to ease their review burden and focusing their actual reviews on PRs that pass the AI checks, and AI-deranged lone developers flooding the code with “AI features” and slopping out 10kloc PRs for no obvious reason.

      Just because a project is using AI code reviews or has an AGENTS.md is not necessarily a red flag. A yellow flag, maybe, but the evidence that the Linux Kernel itself is on that list should serve as an example of why you can’t just kneejerk anti-AI here. If you know anything about Linus Torvalds you know he has zero tolerance for bad code, and the use of AI is not going to change that despite everyone’s fears. If it doesn’t work out, Linus will be the first one to throw it under the bus.

    • WhyJiffie@sh.itjust.works
      link
      fedilink
      English
      arrow-up
      3
      ·
      12 hours ago

      did not know that the serde developer tolnay is a military apologist. I’m disgusted. serde is a very good tool… I’ll think about what to do about this. such a shame…

    • addie@feddit.uk
      link
      fedilink
      English
      arrow-up
      2
      ·
      19 hours ago

      Awesome page, thanks. Have bookmarked.

      Harfbuzz though? That’s going to take some replacing. Hopefully someone will fork an earlier version. The thing that it does (accurate multi-script font shaping) is difficult to do; requires a lot of rule-of-thumb knowledge that’s unlikely to be possessed by a single person, needs a lot of collaboration.