• markstos@lemmy.world
    link
    fedilink
    English
    arrow-up
    34
    ·
    1 year ago

    Solution: Code Style Guidelines doc that the team agrees on. A checkbox in the PR template that affirms that code is compliant with the guidelines.

    This way it’s not personal, it’s a rule that everyone should follow as a shared standard.

    • bob_wiley@lemmy.world
      link
      fedilink
      English
      arrow-up
      16
      arrow-down
      1
      ·
      1 year ago

      I tried going the style guidelines route, but we didn’t have a good code review process to really enforce it. It basically would have ended up being me doing 100% of the reviews. At the time I was just happy to get them to actually use source control properly.

        • bob_wiley@lemmy.world
          link
          fedilink
          English
          arrow-up
          6
          arrow-down
          1
          ·
          1 year ago

          We’re getting there. Though I’m not sure what kind of rule in a CICD process could check to see if a variable name actually made sense. Using snake or camel case, sure, but how does it know if ‘dc_loc_5’ is good or not from the perspective of someone who needs to maintain the code?

      • ripcord@kbin.social
        link
        fedilink
        arrow-up
        3
        ·
        edit-2
        1 year ago

        This sadly sounds like one of the projects on my teamat the moment and it’s horrifying.

        One guy working on it, I’m really the only reviewer. Code is all stuff like this. Variables named j1 through j20, dozens and dozens of nearly identical functions with tons of brute force, copy-pasted code, etc. Works well enough but it’s just horrifying to try to read and review.

        Edit:. Just remembered, he had all these grouped functions passing (and sometimes returning) 60+ identical variables that didn’t need to be local because he refused to use class vars, etc.

        He’s gotten a lot better about this stuff in the last year though

        • whofearsthenight@lemm.ee
          link
          fedilink
          English
          arrow-up
          2
          ·
          edit-2
          1 year ago

          You know, as an amateur with massive impostor syndrome who’s probably going to be applying for jobs soon, this comment and those like it give me strength.

          • bob_wiley@lemmy.world
            link
            fedilink
            English
            arrow-up
            2
            arrow-down
            1
            ·
            1 year ago

            I work with a guy who is constantly patting himself on the back about how great he is, nitpicking everyone’s stuff based on his own ignorance, and bragging about his 20 years in the industry. He is primarily a Python dev and has never written a class. He thinks anyone who write anything in a language he doesn’t know is some kind of wizard. He’s constantly trying to answer people’s questions by posting half—ass answers from ChatGPT. And he will spend months battling for an ideal based of a quick search and 2 minutes of reading; it takes a hammer to the head to get him to back down and admit he’s wrong and didn’t have all the information when he started the fight. Most people just let him go, because they don’t have the energy for it.

            I’ll take an amateur with imposter syndrome looking to learn every single day of the week, over a self-important, know it all, blow hard.